Delete emitter implementations #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav
added a commit
that referenced
this pull request
Oct 21, 2022
…ed (#20) The compile-time check that verifies that SliceEnd and MapEnd are not allowed with ContinueOnError was part of the function that validates instrumentation. This introduced a bug: if that function returned early because the number of emitters was non-zero, it would never run this check. Fix this and add a failing test case. This allowed a bug in our magic.go example files, because they were using SliceEnd/MapEnd despite ContinueOnError. Found while working on #21.
abhinav
force-pushed
the
delete-emitters
branch
from
b6bc9b9
to
7e3bac8
Compare
It was named EventLogger but I'm not tied to the idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes the Zap and Tally emitter implementations from cff to
reduce the dependency footprint.
We'll keep copies of these for use internally.
This also warns users away from using WithEmitter because the API is
expected to change significantly with #11.
Resolves #2
Depends on #20