Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Fix: Added github id with github user details #618

Closed

Conversation

baibhavKumar1
Copy link
Contributor

@baibhavKumar1 baibhavKumar1 commented Aug 14, 2023

No description provided.

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit bd4c2f2
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/64da8df281017b00095383cd
😎 Deploy Preview https://deploy-preview-618--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to do this for other tables access, penalty, wallets, multiplier

@@ -6,6 +6,7 @@ CREATE TYPE issue_status AS ENUM (
);

CREATE TABLE users (
user_id bigint NOT NULL,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a new migration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear about this. Please describe.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrations are only run once, so when you want to make a change to the database you need to make a new migration that will alter the database.

src/adapters/supabase/types/database.ts Show resolved Hide resolved
@@ -90,6 +90,7 @@ export type UserProfileAdditions = {
};
const getDbDataFromUserProfile = (userProfile: UserProfile, additions?: UserProfileAdditions) => {
return {
user_id: userProfile.id,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to also add this field to upsertUser

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, will be implemented in next commit.

Copy link
Contributor

@web4er web4er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A QA to show IDs being inserted correctly without error will be helpful here. One way to do so will be to run the commands when the ID is supposed to be inserted and attach a screenshot. Example web4erOrg#46 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants