-
Notifications
You must be signed in to change notification settings - Fork 61
Fix: Added github id with github user details #618
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to do this for other tables access
, penalty
, wallets
, multiplier
@@ -6,6 +6,7 @@ CREATE TYPE issue_status AS ENUM ( | |||
); | |||
|
|||
CREATE TABLE users ( | |||
user_id bigint NOT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a new migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unclear about this. Please describe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrations are only run once, so when you want to make a change to the database you need to make a new migration that will alter the database.
@@ -90,6 +90,7 @@ export type UserProfileAdditions = { | |||
}; | |||
const getDbDataFromUserProfile = (userProfile: UserProfile, additions?: UserProfileAdditions) => { | |||
return { | |||
user_id: userProfile.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to also add this field to upsertUser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, will be implemented in next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A QA to show IDs being inserted correctly without error will be helpful here. One way to do so will be to run the commands when the ID is supposed to be inserted and attach a screenshot. Example web4erOrg#46 (comment)
No description provided.