Fixed linting errors caused by accessing '@env' module in certain files #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #252 I will check this today |
AlexanderWangY
requested changes
Sep 11, 2024
h1divp
pushed a commit
to KOrtizLedezma/OSC-Proximity-Chat-App
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #257
I noticed this error in the
./client/app/configs/firebaseConfig.tsand./client/app/contexts/LocationContext.tsxfiles.The fix involved modifying the
tsconfig.json,.eslintrc.js, andbabel.config.jsfiles to permit the inclusion of theenv.d.tsfile and@envmodule (a typo in thebabel.config.jsfile also contributed to the error). Additionally, the environment file was moved to the root directory of the client folder from its previous location in./client/app/types.However, I cannot say that the fix is fully proofed as I use an eslint-lsp plugin incorporated with my neovim configuration; the solution's results may vary depending on the linter being used. Other developers can only test the success using their own IDEs or text editors.