[production/RRFS.v1] Update MYNN PBL & Smoke for RRFS.v1 #180
Conversation
haiqinli
commented
Mar 5, 2024
•
haiqinli
commented
- Update the MYNN PBL scheme for the RRFS.v1 code freeze.
- Update the Smoke modules for the RRFS.v1.
- Include the PR [production/RRFS.v1] fix zero cloud fraction for RRFS ensemble members #186.
haiqinli
requested review from
grantfirl,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
grantfirl
changed the title
|
@haiqinli Please merge in the latest production/RRFS.v1 branch. |
haiqinli
force-pushed
the
production/RRFS.v1-mynn
branch
from
0697f26
to
274a696
Compare
haiqinli
changed the title
| @@ -1,18 +1,19 @@ | |||
| !>\file rrfs_smoke_wrapper.F90 | |||
| !>\file rrfs_smoke_wrapper.F90hwp_method | |||
There was a problem hiding this comment.
I'm guessing that adding hwp_method is a mistake in this Doxygen comment?
There was a problem hiding this comment.
@grantfirl Yes, it is a mistake. Fixed. Thanks.
|
@grantfirl Yes, it is fine with me that combining #186 into this. Yes, I will recreate the fv3atm PR when the regression test is done. If we decide to combine #186 into this, I will merge it and redo the regression test. |
OK, let's do that. Please let me know if you need help. Also, when you create the fv3atm PR, be sure to include the changes in NOAA-EMC/fv3atm#801. |
|
@grantfirl Sure, I am starting to merge Jili's PR, and will let you know if I need your help. Thanks for coordinating these efforts. |
|
@grantfirl Yes, #186 has been merged. Thanks. |
|
@MatthewPyle-NOAA @grantfirl @dustinswales tests are done at ufs-community/ufs-weather-model#2170. can you merge this pr? |
dustinswales
merged commit 85fabc0
into
ufs-community:production/RRFS.v1
