[production/RRFS.v1] MYNN PBL & Smoke update for RRFS.v1

[haiqinli]

Commit Queue Requirements:

• [ V] Fill out all sections of this template.
• [ V] All sub component pull requests have been reviewed by their code managers.
• [ V] Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• [ V] Commit 'test_changes.list' from previous step

---

Description:

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - 
    * ccpp-physics - MYNN PBL, Smoke and subgrid cloud fraction.
    * atmos_cubed_sphere - hail diagnostics, and average of smoke/dust.
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * stochastic_physics - 

Priority:

• AQM:
• CDEPS:
• CICE:
• CMEPS:
• CMakeModules:
• FV3:
  • ccpp-physics:[production/RRFS.v1] Update MYNN PBL & Smoke for RRFS.v1 ccpp-physics#180
  • atmos_cubed_sphere: [production/RRFS.v1] Merge the bugfix in the HAILCAST diagnostic code (unit issue) (#320) NOAA-EMC/GFDL_atmos_cubed_sphere#87

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Adds New Tests/Baselines.
• PR Updates/Changes Baselines.
• No Baseline Changes.

Input data Changes:

• None.

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[grantfirl]

@haiqinli Given the physics changes, this PR should change RT baselines. I'm wondering if we could combine this with #2161 and the scientists involved with the RRFS.v1 release could OK the results change for us. @AndersJensen-NOAA is working on looking at the changes from #2161 separately, but if this PR is also changing the answer, it seems like they could be combined and folks (e.g. scientists involved with the RRFS release) could review the output for skill for the combined PRs to save time.

[grantfirl]

@haiqinli Also, are there any more updates coming for the RRFS release? I thought that this was supposed to be frozen a while ago...

[haiqinli]

@grantfirl Sure, let's combine the changes from #2161. We may also add a little smoke diurnal cycle updates into this PR. I hope these are all our changes for the code freeze. Thanks.

[grantfirl]

@haiqinli Who has been involved with approving results changes for the RRFS.v1 release?

[haiqinli]

@haiqinli Who has been involved with approving results changes for the RRFS.v1 release?

Joe, Ravan and Ming.

[grantfirl]

@haiqinli Please merge in the latest production/RRFS.v1 branch

[MatthewPyle-NOAA]

@haiqinli Will echo @grantfirl - can you update your branch so we can proceed with this one?

[haiqinli]

@MatthewPyle-NOAA Sorry, I forgot to push it back. The update is done.

[grantfirl]

@MatthewPyle-NOAA Haiqin said that he is adding one more update to the smoke physics code before we test/approve/merge this one.

[MatthewPyle-NOAA]

Sounds good. Thanks @haiqinli and @grantfirl

[haiqinli]

@grantfirl All the updates and merging works are done, and the regression test is also successfully done. It is ready for testing. Thanks.

[grantfirl]

@MatthewPyle-NOAA @haiqinli I think that we're ready to test this one. @haiqinli has the MYNN PBL, smoke, and cloud fraction changes from @JiliDong-NOAA all staged in this PR and the RT log shows the expected RT failures. @haiqinli Please double-check that the failures listed are all expected. The MYNN PBL changes alone should change the results for all tests using RAP and HRRR suites.

[grantfirl]

@haiqinli Thanks for all of the work combining things. It looks like we were writing a comment at the same time!

[MatthewPyle-NOAA]

I'll test and update the baselines on WCOSS2. Thanks!

[MatthewPyle-NOAA]

Is anyone else having trouble with this PR? I had a few debug tests crash:

hrrr_control_debug_intel 021 failed in run_test
hrrr_gf_debug_intel 022 failed in run_test
hrrr_c3_debug_intel 023 failed in run_test
hrrr_control_debug_dyn32_phy32_intel 042 failed in run_test

All had this complaint about RHO_DRY.

+ mpiexec -n 256 -ppn 128 -depth 1 ./fv3.exe
forrtl: severe (408): fort: (7): Attempt to use pointer RHO_DRY when it is not associated with a target

[grantfirl]

Is anyone else having trouble with this PR? I had a few debug tests crash:

hrrr_control_debug_intel 021 failed in run_test hrrr_gf_debug_intel 022 failed in run_test hrrr_c3_debug_intel 023 failed in run_test hrrr_control_debug_dyn32_phy32_intel 042 failed in run_test

All had this complaint about RHO_DRY.

+ mpiexec -n 256 -ppn 128 -depth 1 ./fv3.exe
forrtl: severe (408): fort: (7): Attempt to use pointer RHO_DRY when it is not associated with a target

I think I know how to fix this, although I'm not sure why these failures weren't caught by @haiqinli 's tests. Please stand by a sec while I take a look.

[grantfirl]

Is anyone else having trouble with this PR? I had a few debug tests crash:

hrrr_control_debug_intel 021 failed in run_test hrrr_gf_debug_intel 022 failed in run_test hrrr_c3_debug_intel 023 failed in run_test hrrr_control_debug_dyn32_phy32_intel 042 failed in run_test

All had this complaint about RHO_DRY.

+ mpiexec -n 256 -ppn 128 -depth 1 ./fv3.exe
forrtl: severe (408): fort: (7): Attempt to use pointer RHO_DRY when it is not associated with a target

@haiqinli @MatthewPyle-NOAA Please see haiqinli/fv3atm#2 for the fix. @haiqinli Please merge this so that tests can be restarted.

[grantfirl]

Is anyone else having trouble with this PR? I had a few debug tests crash:
hrrr_control_debug_intel 021 failed in run_test hrrr_gf_debug_intel 022 failed in run_test hrrr_c3_debug_intel 023 failed in run_test hrrr_control_debug_dyn32_phy32_intel 042 failed in run_test
All had this complaint about RHO_DRY.

+ mpiexec -n 256 -ppn 128 -depth 1 ./fv3.exe
forrtl: severe (408): fort: (7): Attempt to use pointer RHO_DRY when it is not associated with a target

@haiqinli @MatthewPyle-NOAA Please see haiqinli/fv3atm#2 for the fix. @haiqinli Please merge this so that tests can be restarted.

This error only shows up in debug mode because that is when check all is used as a compilation flag.

[haiqinli]

@grantfirl @MatthewPyle-NOAA This fix has been merged. Thanks.

[MatthewPyle-NOAA]

@haiqinli - can you update everything so this PR points at the latest fix?

[haiqinli]

@MatthewPyle-NOAA Sure, it is done. Thanks.

[MatthewPyle-NOAA]

Thanks @haiqinli and @grantfirl - testing on WCOSS went smoothly this time.

[jkbk2004]

@MatthewPyle-NOAA Orion queue has been slow. I think it should be ok to skip orion.

[MatthewPyle-NOAA]

That works for me @jkbk2004

[jkbk2004]

That works for me @jkbk2004

@MatthewPyle-NOAA Great! We can start merging process.

[jkbk2004]

@haiqinli can you update fv3 hash and revert change in gitmodules? correct hash is NOAA-EMC/fv3atm@f9a1759

[haiqinli]

@jkbk2004 The fv3 hash has been updated to NOAA-EMC/fv3atm@f9a1759. Thanks.