coll/barrier: fix op undercount and buffer overflow for non-power-of-two #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-power-of-two node counts, the barrier code would undercount the number of required iterations by one and, therefore, the number of scheduled operations by two. This would result in underallocating the buffer for scheduled operations and, subsequently, a buffer overflow, which would trash memory used internally by malloc and cause a crash.
Fix this by counting correctly. This overcounts (and overallocates) the scheduled operations for power-of-two node counts, but this is harmless, other than allocating an additional 80 bytes.