Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coll/barrier: fix op undercount and buffer overflow for non-power-of-two #67

Merged
merged 1 commit into from
Jan 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lci/experimental/coll/barrier.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ LCI_error_t LCIX_barrier(LCI_endpoint_t ep, LCI_tag_t tag,
return LCI_OK;
}

/* We have at most 2 * ilog2(size) scheduled operations */
sched_ops = 2 * ilog2(size);
/* We have at most 2 * (1 + ilog2(size)) scheduled operations */
sched_ops = 2 * (1 + ilog2(size));

LCIX_collective_t coll = LCIU_malloc(sizeof(struct LCIX_collective_s));
LCIXC_mcoll_init(coll, ep, tag, NULL, completion, user_context, empty,
Expand Down
Loading