Skip to content

Commit

Permalink
Static methods should avoid override check. 22 missings -> 13 missings
Browse files Browse the repository at this point in the history
  • Loading branch information
Atsushi Eno committed Aug 29, 2011
1 parent dbde0b9 commit b43a3a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion JavaClass.java
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ public void appendToDocument (Document doc, Element parent)
// Removing this entire block however results in more confusion. See README.
int base_mods = base_method.getModifiers ();
int base_decl_class_mods = base_method.getDeclaringClass ().getModifiers (); // This is to not exclude methods that are excluded in the base type by modifiers (e.g. some AbstractStringBuilder methods)
if (!Modifier.isAbstract (base_mods) && (Modifier.isPublic (mmods) == Modifier.isPublic (base_mods)) && Modifier.isPublic (base_decl_class_mods)) {
if (!Modifier.isStatic (base_mods) && !Modifier.isAbstract (base_mods) && (Modifier.isPublic (mmods) == Modifier.isPublic (base_mods)) && Modifier.isPublic (base_decl_class_mods)) {
if (!Modifier.isAbstract (mmods) || method.getName ().equals ("finalize")) // this is to not exclude some "override-as-abstract" methods e.g. android.net.Uri.toString(), android.view.ViewGroup.onLayout()
continue;
}
Expand Down

0 comments on commit b43a3a8

Please sign in to comment.