fix lagoon logging test #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smlx
commented
Feb 21, 2024
smlx
commented
- fix: add missing helm hook annotations to test objects
- chore: bump lagoon-logging chart version
Previously the test role and rolebinding were being installed unconditionally. With this change they are only installed when running helm test and then removed. Having the role and rolebinding installed unconditionally would mean that any serviceaccount (including the default) would be able to view service objects in the lagoon-logging namespace. This is an unnecessary elevation of privilege, but these service objects do not contain anything sensitive.
smlx
force-pushed
the
fix-lagoon-logging-test
branch
from
62c6cad to
5bbf46c
Compare
tobybellwood
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.