Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lagoon logging test #643

Merged
merged 4 commits into from
Feb 22, 2024
Merged

fix lagoon logging test #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4db1425
fix: add missing helm hook annotations to test objects
smlx Feb 21, 2024
5bbf46c
chore: bump lagoon-logging chart version
smlx Feb 21, 2024
9d53479
chore: reduce artifacthub changelog entry to one line
smlx Feb 21, 2024
fda8f28
chore: ensure test objects are installed in the correct order
smlx Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions charts/lagoon-logging/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type: application
# time you make changes to the chart and its templates, including the app
# version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.81.0
version: 0.81.1

dependencies:
- name: logging-operator
Expand All @@ -31,6 +31,7 @@ dependencies:
# It should be started afresh for each release
# Valid supported kinds are added, changed, deprecated, removed, fixed and security
annotations:
artifacthub.io/containsSecurityUpdates: "true"
artifacthub.io/changes: |
- kind: added
description: support for annotations on the CDN service
- kind: security
description: avoid test role and rolebinding being wrongly installed
10 changes: 10 additions & 0 deletions charts/lagoon-logging/templates/tests/cdn-service-annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: service-reader
annotations:
"helm.sh/hook": test
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
"helm.sh/hook-weight": "-2"
rules:
- apiGroups: [""] # "" indicates the core API group
resources: ["services"]
Expand All @@ -12,6 +16,10 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: read-services
annotations:
"helm.sh/hook": test
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
"helm.sh/hook-weight": "-1"
subjects:
- kind: Group
name: system:serviceaccounts # all serviceaccounts
Expand All @@ -29,6 +37,8 @@ metadata:
{{- include "lagoon-logging.logsDispatcher.labels" . | nindent 4 }}
annotations:
"helm.sh/hook": test
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
"helm.sh/hook-weight": "0"
spec:
containers:
- name: kubectl
Expand Down
1 change: 1 addition & 0 deletions charts/lagoon-logging/templates/tests/test-connection.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ metadata:
{{- include "lagoon-logging.logsDispatcher.labels" . | nindent 4 }}
annotations:
"helm.sh/hook": test
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
spec:
containers:
- name: nc
Expand Down
Loading