-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce v1beta2 and deprecate v1beta1 #247
Conversation
ca3dd55
to
5b85a14
Compare
6c9d7b6
to
7c53977
Compare
1dc284e
to
3797bf7
Compare
3797bf7
to
f7e12fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay - the logic of the move looks sound. I've gone through the code as best as I can. Tests make sense.
There are a couple of other PRs that will introduce changes to the CRD, so this PR should be merged before those other PRs are so that a single CRD release can be done with all the new features. |
Going to merge this into a new branch |
Checklist
Introduces v1beta2, but announces the deprecation of the v1beta1. The main part of this is to make isolating v1beta1 and v1beta2 interactions so that future version changes of the underlying CRDs can be done easier. This means that steps like this are not required to be performed if the updated CRD versions are included in the chart.
Since v1beta2 is the supported controller version from this release, this means that all new messages from core will be created using v1beta2. Existing v1beta1 builds and tasks that may exist at the time the controller is upgraded will still be able to function using the v1beta1 controllers. This allows for a transition period of potentially running builds to complete. Once builds complete, the v1beta1 endpoint is effectively unusable outside of direct kubernetes interactions.
A future release will move the v1beta1 controllers into a cleanup mode only where it will not create any new resources, and will only remove old resources. After that another release will then completely remove v1beta1.