Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce v1beta2 and deprecate v1beta1 #247

Merged
merged 8 commits into from
May 2, 2024

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Introduces v1beta2, but announces the deprecation of the v1beta1. The main part of this is to make isolating v1beta1 and v1beta2 interactions so that future version changes of the underlying CRDs can be done easier. This means that steps like this are not required to be performed if the updated CRD versions are included in the chart.

Since v1beta2 is the supported controller version from this release, this means that all new messages from core will be created using v1beta2. Existing v1beta1 builds and tasks that may exist at the time the controller is upgraded will still be able to function using the v1beta1 controllers. This allows for a transition period of potentially running builds to complete. Once builds complete, the v1beta1 endpoint is effectively unusable outside of direct kubernetes interactions.

A future release will move the v1beta1 controllers into a cleanup mode only where it will not create any new resources, and will only remove old resources. After that another release will then completely remove v1beta1.

@shreddedbacon shreddedbacon force-pushed the v1beta2-api branch 6 times, most recently from ca3dd55 to 5b85a14 Compare January 9, 2024 21:35
@shreddedbacon shreddedbacon force-pushed the v1beta2-api branch 2 times, most recently from 6c9d7b6 to 7c53977 Compare January 23, 2024 20:56
@shreddedbacon shreddedbacon requested a review from bomoko January 23, 2024 21:03
@shreddedbacon shreddedbacon force-pushed the v1beta2-api branch 5 times, most recently from 1dc284e to 3797bf7 Compare January 24, 2024 02:44
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay - the logic of the move looks sound. I've gone through the code as best as I can. Tests make sense.

@shreddedbacon
Copy link
Member Author

There are a couple of other PRs that will introduce changes to the CRD, so this PR should be merged before those other PRs are so that a single CRD release can be done with all the new features.

@shreddedbacon shreddedbacon changed the base branch from main to main-v1beta2 May 1, 2024 23:51
@shreddedbacon
Copy link
Member Author

Going to merge this into a new branch main-v1beta2 that will be used for being able to stage all PRs that need to go into it. then we can look at a merging main-v1beta2 into main once all accompanying PRs are merged.

@shreddedbacon shreddedbacon marked this pull request as ready for review May 2, 2024 00:07
@shreddedbacon shreddedbacon merged commit 0edaad6 into main-v1beta2 May 2, 2024
10 checks passed
@shreddedbacon shreddedbacon deleted the v1beta2-api branch May 2, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants