Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework maven code for faster calculation of path config #1661

Merged
merged 21 commits into from
Nov 26, 2024

Conversation

DavyLandman
Copy link
Member

@DavyLandman DavyLandman commented Oct 3, 2022

This needs effort to make this work together with our shaded jars.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Attention: Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (5b9e319) to head (c82fbc9).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/PathConfig.java 38% 8 Missing ⚠️
src/org/rascalmpl/library/util/Maven.java 82% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #1661   +/-   ##
=======================================
- Coverage       49%     49%   -1%     
- Complexity    6311    6312    +1     
=======================================
  Files          665     666    +1     
  Lines        59616   59616           
  Branches      8649    8649           
=======================================
- Hits         29502   29500    -2     
  Misses       27895   27895           
- Partials      2219    2221    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

On windows increases speed from 14s to 2s
…y, changing output streams, hoping it's not a race)
@jurgenvinju
Copy link
Member

The idea would be to turn this PR into a general utility/service for Maven-related features for Rascal:

  • dependency resolution
  • exploration and install of new components in the REPL/IDE

Davy's setup allows for a lean and fast application of maven features.

@rodinaarssen rodinaarssen marked this pull request as ready for review August 27, 2024 09:50
Copy link
Member Author

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for finishing it @rodinaarssen

src/org/rascalmpl/library/util/Maven.java Show resolved Hide resolved
@rodinaarssen rodinaarssen merged commit b2a3042 into main Nov 26, 2024
7 checks passed
@rodinaarssen rodinaarssen deleted the reduce-maven-overhead branch November 26, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants