-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework maven code for faster calculation of path config #1661
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
=======================================
- Coverage 49% 49% -1%
- Complexity 6311 6312 +1
=======================================
Files 665 666 +1
Lines 59616 59616
Branches 8649 8649
=======================================
- Hits 29502 29500 -2
Misses 27895 27895
- Partials 2219 2221 +2 ☔ View full report in Codecov by Sentry. |
On windows increases speed from 14s to 2s
…y, changing output streams, hoping it's not a race)
The idea would be to turn this PR into a general utility/service for Maven-related features for Rascal:
Davy's setup allows for a lean and fast application of maven features. |
Co-authored-by: Davy Landman <[email protected]>
…ependency injection in maven-embedder
…ting maven classpath to disk
a4d1565
to
718a6b3
Compare
718a6b3
to
2aab716
Compare
…call as all output is suppressed anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for finishing it @rodinaarssen
This needs effort to make this work together with our shaded jars.