Remove broken links from Showcase page and correct spelling #2586
Conversation
Remove broken links that have no alternate for redirects. Will improve QA on site.
Removed another link
There was a problem hiding this comment.
@finekatie only found references for move.mil on a blog post. The rest don't appear anywhere.
| @@ -93,7 +91,6 @@ If your project is currently using USWDS and you would like to see it included i | |||
| - [Manufacturing USA](https://www.manufacturing.gov/) | |||
| - [Medicaid](https://www.medicaid.gov/) | |||
| - [Method Cards - 18F](https://methods.18f.gov/) | |||
| - [Move.mil — Official DOD Moving Portal](https://www.move.mil/) | |||
There was a problem hiding this comment.
This URL appears in _posts/2018-03-22-dds-case-study.md.
Live preview
How the Defense Digital Service uses USWDS for a Ruby app | U.S. Web Design System (USWDS).
There was a problem hiding this comment.
Thank you James. We'll address that page and work to be done in another issue and PR when we go to clean up old blog pages.
| @@ -93,7 +91,6 @@ If your project is currently using USWDS and you would like to see it included i | |||
| - [Manufacturing USA](https://www.manufacturing.gov/) | |||
| - [Medicaid](https://www.medicaid.gov/) | |||
| - [Method Cards - 18F](https://methods.18f.gov/) | |||
| - [Move.mil — Official DOD Moving Portal](https://www.move.mil/) | |||
| - [MyMedicare](https://www.mymedicare.gov/) | |||
| - [NASA General Coordinates Network (GCN)](https://gcn.nasa.gov) | |||
| - [NASA Glenn Research Center](https://www1.grc.nasa.gov) | |||
There was a problem hiding this comment.
@finekatie - while we're updating the page can we also correct the spelling of "Satellite" in "National Environmental Sattelite Data and Information Service (NOAA)" (This issue was also flagged in the Siteimprove report.)
There was a problem hiding this comment.
Hey there, @sarah-sch , I can, but since this isn't a broken link, do I need to update the Issue, etc.?
There was a problem hiding this comment.
Discussed with @finekatie on 4/2 and updated issue
There was a problem hiding this comment.
Corrected the misspelling. This is ready for review and approval.
There was a problem hiding this comment.
Confirming this is fixed in 64f6c0c.
sarah-sch
changed the title
Corrected spelling on one of the site names.
|
@finekatie I've updated the labels in the original issue. Also confirming there aren't any |
|
It looks like we've added changelogs for removed links before. Should we add a changelog to the showcase page? There currently isn't a changelog section for this page. Happy to create if we decide we want one! Example: About research page |
Hi Charlie! We are talking about this as I write this. In favor of a changelog. Thank you! |
_data/changelogs/docs-showcase.yml
Outdated
| title: Showcase | ||
| type: documentation | ||
| changelogURL: | ||
| items: | ||
| - date: NNNN-NN-NN | ||
| summary: Remove broken links that have no alternate for redirects. | ||
| summaryAdditional: Correct misspelling that Siteimprove noted. | ||
| affectsGuidance: true | ||
| githubPr: 2586 | ||
| githubRepo: uswds-site |
There was a problem hiding this comment.
Created changelog
After discussing with the team, we decided to add a changelog and keep track of larger changes such as addition and removal of links.
|
Hey @mahoneycm , are you able to take a look at this? Looks like checks are failing even though Dan approved. |
Let's now link to the newer Digital Experience Council
|
@finekatie I'm on it. We needed to update another broken link |
|
Merging over unrelated pa11y crash |
Summary
Remove broken links that have no alternate for redirects. Correct misspelling that Siteimprove noted. Will improve QA on site.
Related issue #2567
Also related to: #2346 and #2407
Closes #2567
Preview link
Showcase page
Problem statement
Broken links and misspelling on this page contributes to drop in QA.
Solution
Removing old broken links and correcting spelling will improve content relevancy and QA.
Changes
https://datacenters.cio.gov/ remove
https://feedback.usa.gov/ remove
https://itmodernization.cio.gov/ remove
https://www.move.mil/ remove
http://vsfs.state.gov/ remove
Testing and review
Will need to have someone review to make sure links and copy are gone and that spelling is correct.
Check that changelog is implemented correctly and the content is correct.