Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken macro for XPU tests #2000

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

dmitriy-sobolev
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev commented Jan 15, 2025

Updating the macro version, since these tests fail with newer compiler versions (icpx 2025.0.4 and internal builds for the next release).

Some values were also changes:

  • _PSTL_LAMBDA_PTR_TO_MEMBER_WINDOWS_BROKEN: set to <20250200 since the update is expected with that compiler version.
  • _PSTL_TEST_COMPARISON_BROKEN and _PSTL_RED_BY_SEG_WINDOWS_COMPILE_ORDER_BROKEN: set <20250100 since the issues do not reproduce with icpx 2025.0.
  • _PSTL_ICPX_FPGA_TEST_USM_VECTOR_ITERATOR_BROKEN was set to <20250100 since it is expected to be fixed with that version (not-verified yet, but we can raise the version in the future if needed).

@dmitriy-sobolev dmitriy-sobolev added the test Test only Change label Jan 15, 2025
SergeyKopienko
SergeyKopienko previously approved these changes Jan 15, 2025
Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyKopienko SergeyKopienko added this to the 2022.8.0 milestone Jan 15, 2025
@dmitriy-sobolev
Copy link
Contributor Author

LGTM

I've corrected the PR to limit it to the XPU tests only.

Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at the reduce_by_segment case and it LGTM as it passes with 2025.1.0.

test/support/test_config.h Outdated Show resolved Hide resolved
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitriy-sobolev dmitriy-sobolev merged commit 6a2d9b1 into main Jan 17, 2025
22 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/lin-xpu-upd branch January 17, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test only Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants