-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update broken macro for XPU tests #2000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've corrected the PR to limit it to the XPU tests only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look at the reduce_by_segment
case and it LGTM as it passes with 2025.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updating the macro version, since these tests fail with newer compiler versions (icpx 2025.0.4 and internal builds for the next release).
Some values were also changes:
_PSTL_LAMBDA_PTR_TO_MEMBER_WINDOWS_BROKEN
: set to <20250200 since the update is expected with that compiler version._PSTL_TEST_COMPARISON_BROKEN
and_PSTL_RED_BY_SEG_WINDOWS_COMPILE_ORDER_BROKEN
: set <20250100 since the issues do not reproduce with icpx 2025.0._PSTL_ICPX_FPGA_TEST_USM_VECTOR_ITERATOR_BROKEN
was set to <20250100 since it is expected to be fixed with that version (not-verified yet, but we can raise the version in the future if needed).