-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing config.json to support #892 #128
Conversation
I don't think the python CodeQL is related to my JSON file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you add a new file, you also need to add that file to CMakeLists.txt, otherwise it simply does not get installed when you make install.
It would make sense to make that change to CMakeLists.txt as part of this pull request.
Yup, that did it, vegastrike now launches with this pull request. ;) |
I'm still waiting on confirmation from @BenjamenMeyer on the codeQL stuff. |
I don't think the python CodeQL is related to my JSON file. However, this error is absent from my other PR and is recurring. Rerunning the process doesn't fix it. @BenjamenMeyer can you shed some light here? Did I get in the middle of two of your PR's. There's nothing here for me to work with. |
Might be we need to update the GitHub Action...it's having trouble reading some results or something...not sure what the SARIF is. But just a guess. It's on the Python module so no, not related to your code afaict |
OK. I'm merging this. We'll monitor this further. |
This is the complementing config.json for #892.
Please answer the following:
Code Changes:
Issues: