Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing config.json to support #892 #128

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Add missing config.json to support #892 #128

merged 2 commits into from
Oct 27, 2024

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Oct 16, 2024

This is the complementing config.json for #892.

Please answer the following:

Code Changes:

Issues:

  • This temporarily deprecates the settings app.

@royfalk royfalk self-assigned this Oct 16, 2024
@royfalk
Copy link
Contributor Author

royfalk commented Oct 16, 2024

I don't think the python CodeQL is related to my JSON file.

Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you add a new file, you also need to add that file to CMakeLists.txt, otherwise it simply does not get installed when you make install.

It would make sense to make that change to CMakeLists.txt as part of this pull request.

@evertvorster
Copy link
Contributor

Yup, that did it, vegastrike now launches with this pull request.
So, it is all good, and this pull request should be merged.

;)

@royfalk
Copy link
Contributor Author

royfalk commented Oct 20, 2024

Yup, that did it, vegastrike now launches with this pull request. So, it is all good, and this pull request should be merged.

;)

I'm still waiting on confirmation from @BenjamenMeyer on the codeQL stuff.

@royfalk
Copy link
Contributor Author

royfalk commented Oct 25, 2024

I don't think the python CodeQL is related to my JSON file. However, this error is absent from my other PR and is recurring. Rerunning the process doesn't fix it.

@BenjamenMeyer can you shed some light here? Did I get in the middle of two of your PR's. There's nothing here for me to work with.

@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Oct 26, 2024
@BenjamenMeyer
Copy link
Member

Might be we need to update the GitHub Action...it's having trouble reading some results or something...not sure what the SARIF is. But just a guess.

It's on the Python module so no, not related to your code afaict

@royfalk
Copy link
Contributor Author

royfalk commented Oct 27, 2024

OK. I'm merging this. We'll monitor this further.

@royfalk royfalk merged commit a72b16f into master Oct 27, 2024
10 of 11 checks passed
@royfalk royfalk deleted the task_config_json branch October 27, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants