Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Contact documentation #414

Merged

Conversation

BenjamenMeyer
Copy link
Member

@BenjamenMeyer BenjamenMeyer commented Jan 27, 2021

This contributes to the following stories:
vegastrike/infrastructure-tracking#1
#96
vegastrike/infrastructure-tracking#6

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

Purpose:
Document our means of contacts, submitting bugs, etc where it'll get passed out with releases, source, etc.
Rename binaries per naming convention in #178.

@BenjamenMeyer BenjamenMeyer added this to the 0.7.x milestone Jan 27, 2021
@BenjamenMeyer BenjamenMeyer self-assigned this Jan 27, 2021
Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one small typo, everything looks good.

README.md Outdated Show resolved Hide resolved
- Rename the internal static libraries to vegastrike-* per vegastrike#178
- Rename the internal non-distributed binaries  to vs-buildenv-*
  per vegastrike#178
@BenjamenMeyer
Copy link
Member Author

Note: Packaged 6a6a8f5 in here because of already packaging c7a6e99 and the discussion in #178 related to c7a6e99 resolved by #178 (comment). Therefore this should be able to close out #178 in addition to the other issues once it's backported to master.

Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@BenjamenMeyer BenjamenMeyer merged commit f583b31 into vegastrike:0.7.x Feb 1, 2021
@BenjamenMeyer BenjamenMeyer mentioned this pull request Feb 11, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants