Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ship view to python (partial) #899

Merged
merged 13 commits into from
Nov 1, 2024
Merged

Move ship view to python (partial) #899

merged 13 commits into from
Nov 1, 2024

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Oct 27, 2024

This moves the ship view to a python script. It provides the script with a dictionary generated in the same code as unit saves. It will allow modification by different games. e.g. antimatter as fuel as well as localization.
This PR covers most text up to armament section. Missing cloak.

Code Changes:

Issues:

  • None

Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mixed on moving more to Python... but aside from that, mostly concerned about the copying time for the map since it will probably hold all our ships and their variants, no?

@BenjamenMeyer
Copy link
Member

still a bit mixed on moving stuff to Python but my other concerns alleviated so approved

@royfalk royfalk merged commit bcede01 into master Nov 1, 2024
43 checks passed
@royfalk royfalk deleted the task_ship_info_2 branch November 1, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants