Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task bug 924 #926

Merged
merged 16 commits into from
Dec 8, 2024
Merged

Task bug 924 #926

merged 16 commits into from
Dec 8, 2024

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Dec 5, 2024

Close #924

Code Changes:

royfalk added 16 commits December 1, 2023 11:07
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
5e0c681 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d5f7361 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d08bfcf 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
5126833 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
7fb35f5 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
ad5c297 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
08daa5b 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
4354d63 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
606f5d4 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d7dc075 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
b7ce610 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
bd42430 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
4f72ce2 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
a86672e 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
4ac74e8 
…gine-Source
@royfalk
Fix bug 924
a1a6c42
@royfalk royfalk self-assigned this Dec 5, 2024
evertvorster
evertvorster approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR definitely fixes the problem.
It is good to go.
On a new campaign I also see the proper values for turning response, and when saving and loading that game I still have normal flight controls.

@royfalk
Copy link
Contributor Author

royfalk commented Dec 8, 2024

With the disabling of MacOS 12 CI, all tests now pass, merging.

@royfalk royfalk merged commit 69e3fb2 into master Dec 8, 2024
35 of 43 checks passed
@royfalk royfalk deleted the task_bug_924 branch December 8, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertvorster evertvorster evertvorster approved these changes

@BenjamenMeyer BenjamenMeyer BenjamenMeyer approved these changes

Assignees

@royfalk royfalk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No flight controls after loading a saved game from a new campaign.
3 participants
@royfalk @BenjamenMeyer @evertvorster