Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: SDL2 support #43

Merged

Conversation

BenjamenMeyer
Copy link
Member

Vega Strike is moving to use SDL2. Add support to the docker images for SDL2 in addition to SDL1.

  • add a tool to easily check that the script works locally
  • ignore Vi Swap files

Thank you for submitting a pull request and becoming a contributor to Vega Strike's Build System Docker Images.

Please answer the following:

Code Changes:

  • This is a documentation change only
  • CI Change

Issues:

Purpose:

  • What is this pull request trying to do? Adds SDL2 Dev libraries
  • What release is this for? Adding SDL2 support
  • Is there a project or milestone we should apply this to? 0.9.x

Vega Strike is moving to use SDL2. Add support to the docker images
for SDL2 in addition to SDL1.

- add a tool to easily check that the script works locally
- ignore Vi Swap files
@BenjamenMeyer BenjamenMeyer added the enhancement New feature or request label Sep 30, 2023
@BenjamenMeyer BenjamenMeyer self-assigned this Sep 30, 2023
@BenjamenMeyer
Copy link
Member Author

NOTE: We already removed Kinetic from the VS Engine repo.

@royfalk
Copy link

royfalk commented Sep 30, 2023

Looks fine to me. I did remember that I needed to touch this repo as well but wasn't sure when to do it (before or after) we merge the main PR.
One comment - should we keep sdl1.2?

Copy link

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comment about SDL1.2, it looks fine.

@BenjamenMeyer
Copy link
Member Author

Keeping the SDL 1.x for now. We still have releases that use it . We can clean that up after 0.9.x gets released

@BenjamenMeyer BenjamenMeyer merged commit 2b974c1 into vegastrike:master Sep 30, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants