Deep handle mongo ID_FIELD when useObjectId #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsegismont
reviewed
Oct 13, 2023
tsegismont
reviewed
Nov 6, 2023
src/test/java/io/vertx/ext/mongo/MongoClientWithObjectIdTest.java
Outdated
Show resolved
Hide resolved
liuchong
force-pushed
the
deep-handle-use-object-id
branch
from
b008bd0 to
9053850
Compare
tsegismont
approved these changes
Nov 8, 2023
tsegismont
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Deep encode key when use object id * Use deepEncodeKeyWhenUseObjectId only in query or filter * Fix deepEncodeKeyWhenUseObjectId should not use on bulk INSERT * Add unit tests for deepEncodeKeyWhenUseObjectId for MongoClient * Handle Map and List for deepEncodeKeyWhenUseObjectId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If we give a query when "_id" field in a nested value like:
{ "$and":[ { "_id":"an-id-field" }, { "some":"other" } ] }then, the nested "_id" will not be encoded.
I added a deep version of this method for handling this, we should only need this in query or filter.
Please review this @tsegismont @vietj 👀 If this logic is acceptable, I will complete the test cases, thanks!