Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client proxy webhook rule #1000

Merged
merged 21 commits into from
Dec 17, 2024
Merged

Client proxy webhook rule #1000

merged 21 commits into from
Dec 17, 2024

Conversation

HaoYang0000
Copy link
Collaborator

@HaoYang0000 HaoYang0000 commented Dec 11, 2024

  1. client proxy annotation "vertica.com/use-client-proxy: "true""
    cannot be changed(update, add, delete) after vdb is created
  2. image of client proxy cannot be changed(update, add, delete) after vdb is created
  3. if proxy is enabled, spec.proxy must be set and image must be non-empty.
  4. if proxy is enabled, spec.subclusters[].proxy must be set, and replicas must be >= 0(at all times) and >= 1(for any new subcluster in the vdb)
  5. check that the log level is one of these : TRACE|1=DEBUG|2=INFO|3=WARN|4=FATAL|5=NONE

@roypaulin
Copy link
Collaborator

Could you also add the following rules:

  • if proxy is enabled, spec.proxy must be set and image must be non-empty.
  • if proxy is enabled, spec.subclusters[].proxy must be set, and replicas must be >= 0(at all times) and >= 1(for any new subcluster in the vdb)

@roypaulin
Copy link
Collaborator

I made some api changes in my current PR. spec.proxy is now a pointer.

api/v1/verticadb_webhook.go Outdated Show resolved Hide resolved
api/v1/verticadb_webhook.go Outdated Show resolved Hide resolved
api/v1/verticadb_webhook.go Outdated Show resolved Hide resolved
api/v1/verticadb_webhook.go Outdated Show resolved Hide resolved
api/v1/verticadb_webhook.go Outdated Show resolved Hide resolved
@HaoYang0000 HaoYang0000 merged commit e718876 into main Dec 17, 2024
40 checks passed
@HaoYang0000 HaoYang0000 deleted the client-proxy-webhook-rule branch December 17, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants