Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client proxy webhook rule #1000

Merged
merged 21 commits into from
Dec 17, 2024
Merged

Client proxy webhook rule #1000

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2a0f49f
Add webhook in verticadb, avoid change proxy annotation and image aft…
HaoYang0000 Dec 11, 2024
42adb8f
Add unit test
HaoYang0000 Dec 11, 2024
ad4b8f8
fix name style in unit test
HaoYang0000 Dec 11, 2024
9812f4d
move proxy immutable a seperate function, add new validation webhooks
HaoYang0000 Dec 12, 2024
02935dd
Merge branch 'main' into client-proxy-webhook-rule
HaoYang0000 Dec 12, 2024
bf57371
fix pointer
HaoYang0000 Dec 12, 2024
32aba71
fix fmt type
HaoYang0000 Dec 12, 2024
a5a60da
fix logic
HaoYang0000 Dec 12, 2024
f69a227
handle nil pointer
HaoYang0000 Dec 12, 2024
c2e5d6c
handle seperately
HaoYang0000 Dec 12, 2024
7559b8a
fix condition
HaoYang0000 Dec 12, 2024
087338d
update unit test
HaoYang0000 Dec 12, 2024
4dcb8ef
handle nil case
HaoYang0000 Dec 12, 2024
42ee971
address comments
HaoYang0000 Dec 13, 2024
ef2eceb
add new unit test case
HaoYang0000 Dec 13, 2024
24fc8b2
add one more condition check
HaoYang0000 Dec 16, 2024
f6417fa
add condition check
HaoYang0000 Dec 16, 2024
493dc01
Merge branch 'main' into client-proxy-webhook-rule
HaoYang0000 Dec 16, 2024
c87dabc
return upper string
HaoYang0000 Dec 16, 2024
9345ff2
Update api/v1/verticadb_webhook.go
HaoYang0000 Dec 16, 2024
ebadddb
Update webhook
roypaulin Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions api/v1/verticadb_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,6 +1286,22 @@ func (v *VerticaDB) checkImmutableBasic(oldObj *VerticaDB, allErrs field.ErrorLi
"local.storageClass cannot change after creation")
allErrs = append(allErrs, err)
}
// annotation vertica.com/use-client-proxy cannot change after creation
if v.Annotations[vmeta.UseVProxyAnnotation] != oldObj.Annotations[vmeta.UseVProxyAnnotation] {
prefix := field.NewPath("metadata").Child("annotations")
errMsg := fmt.Sprintf("annotation %s cannot change after creation", vmeta.UseVProxyAnnotation)
err := field.Invalid(prefix.Key(vmeta.UseVProxyAnnotation),
v.Annotations[vmeta.VClusterOpsAnnotation],
errMsg)
allErrs = append(allErrs, err)
}
// proxy.image cannot change after creation
if v.Spec.Proxy.Image != oldObj.Spec.Proxy.Image {
err := field.Invalid(field.NewPath("spec").Child("proxy").Child("image"),
v.Spec.Proxy.Image,
"proxy.image cannot change after creation")
allErrs = append(allErrs, err)
}
HaoYang0000 marked this conversation as resolved.
Show resolved Hide resolved
// when update subcluster names, there should be at least one sc's name match its old name.
// This limitation should not be hold in online upgrade since we need to rename all subclusters
// after sandbox promotion.
Expand Down
10 changes: 10 additions & 0 deletions api/v1/verticadb_webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,16 @@ var _ = Describe("verticadb_webhook", func() {
vdbUpdate.Spec.Local.StorageClass = "MyStorageClass"
validateImmutableFields(vdbUpdate, true)
})
It("should not change proxy.image after creation", func() {
vdbUpdate := createVDBHelper()
vdbUpdate.Spec.Proxy.Image = "NewProxyImage"
validateImmutableFields(vdbUpdate, true)
})
It("should not change annotation vertica.com/use-client-proxy after creation", func() {
vdbUpdate := createVDBHelper()
vdbUpdate.Annotations[vmeta.UseVProxyAnnotation] = "NewValue"
validateImmutableFields(vdbUpdate, true)
})
It("should not change local.depotVolume after DB init", func() {
vdbUpdate := createVDBHelper()
vdbUpdate.Spec.Local.DepotVolume = EmptyDir
Expand Down
Loading