Fix parameter having object type in PHPDoc and only & in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter

[kubawerlos]

Sorry for the title, see the explanation below:

Having such code:

<?php
class Foo {
    /**
    * @param object $o
    */
    public function bar(&$o): void {}
}
$x = new Foo();
$x->bar($x);

will result in internal Psalm error.

1. Removing object from PHPDoc, or
2. removing & from the function's definition, or
3. not passing $x to method of $x

will result in Psalm not crashing, so this is quite an edge case.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/3374fc1feb

<?php
class Foo {
    /**
    * @param object $o
    */
    public function bar(&$o): void {}
}
$x = new Foo();
$x->bar($x);

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/MethodCallAnalyzer.php: We must have some types here!

[weirdan]

Thanks!