Draft: Renovate: Ignore packages we don't want to upgrade ATM #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdax98
force-pushed
the
ignore-renovate
branch
from
954a796 to
e1e5c61
Compare
thomasdax98
force-pushed
the
ignore-renovate
branch
from
e1e5c61 to
1176350
Compare
manuelblum
reviewed
Jan 7, 2025
| }, | ||
|
|
||
| { | ||
| // Can't upgrade because: > v5 doesn't support Prompts, so we don't want to upgrade atm |
There was a problem hiding this comment.
I think react-router offers an API for this. useBlocker API can block navigation on certain conditions. I don't know our comet's implementation details and usage of react router Prompt in depth, but I am pretty sure, it should be possible since react-router Version 6.7.0 with unstable_useblocker.
UseBlocker Feature should already be stable in latest react router version.
There was a problem hiding this comment.
Ah true, then we can try that. I must have missed it. If we also do the switch to ESM, then this PR is obsolete
manuelblum
reviewed
Jan 7, 2025
thomasdax98
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some packages that we can't / don't want to upgrade ATM. I listed them in the renovate config and added the reason why we ignore them so that
Switch to json5 to allow comments (is supported by renovate)