Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Renovate: Ignore packages we don't want to upgrade ATM #3023

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from
Draft

Draft: Renovate: Ignore packages we don't want to upgrade ATM #3023

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9246e1
Tell renovate to ignore packages we don't want to upgrade ATM
thomasdax98 Jan 3, 2025
1176350
Switch to json5 to allow comments
thomasdax98 Jan 3, 2025
1cb3b0e
Remove test comment
thomasdax98 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions renovate.json → renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,34 @@
{
"matchUpdateTypes": ["major"],
"labels": ["major", "dependencies"]
},

{
// Can't upgrade because: > v5 doesn't support Prompts, so we don't want to upgrade atm
Copy link
Collaborator

@manuelblum manuelblum Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think react-router offers an API for this. useBlocker API can block navigation on certain conditions. I don't know our comet's implementation details and usage of react router Prompt in depth, but I am pretty sure, it should be possible since react-router Version 6.7.0 with unstable_useblocker.

UseBlocker Feature should already be stable in latest react router version.

Copy link
Member Author

@thomasdax98 thomasdax98 Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah true, then we can try that. I must have missed it. If we also do the switch to ESM, then this PR is obsolete

"matchPackageNames": ["react-router", "react-router-dom", "@types/react-router", "@types/react-router-dom"],
"allowedVersions": "^5.0.0"
},
{
// Can't upgrade because: react-router v5 has a dependency to history v4
"matchPackageNames": ["history", "@types/history"],
"allowedVersions": "^4.0.0"
},
{
// Can't upgrade because: draft-js only supports v3.7.4
"matchPackageNames": ["immutable", "@types/immutable"],
"allowedVersions": "^3.7.4"
},
{
// Can't upgrade because: v5 is pure ESM
"matchPackageNames": ["change-case"],
"matchFileNames": ["packages/**"],
"allowedVersions": "^4.0.0"
},
{
// Can't upgrade because: v8 is pure ESM
"matchPackageNames": ["query-string"],
"matchFileNames": ["packages/**"],
"allowedVersions": "^7.0.0",
}
],
"rangeStrategy": "bump",
Expand Down