This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Add check for configuration value to set function handler via CLI #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-su
force-pushed
the
suan/update-python-buildpack
branch
from
687d1bb to
0a3dde0
Compare
|
lgtm |
joeeltgroth
approved these changes
May 31, 2022
This adds a new configuration `BP_FUNCTION` to the Python buildpack. The check for `func.yaml` is now optional as long as the configuration is defined. Signed-off-by: Andrew Su <[email protected]>
andrew-su
force-pushed
the
suan/update-python-buildpack
branch
from
0a3dde0 to
4f34b5a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes: #63
This adds two configuration options for the buildpack.
BP_FUNCTIONto specify the Python module and function.Testing done
Tested it on our sample. (with func.yaml | it detects and builds the image)
Tested it on our sample. (without func.yaml | it fails detect, this was expected)
Tested it on our sample. (without func.yaml but specified env variables | it detects and builds the image)
Alternatively I can switch this to the split version.
Looking for opinions!