Support k8s 1.28 #1630
Merged
Support k8s 1.28 #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1630 +/- ##
==========================================
- Coverage 75.48% 75.44% -0.04%
==========================================
Files 166 166
Lines 15078 15082 +4
==========================================
- Hits 11381 11379 -2
- Misses 3399 3405 +6
Partials 298 298
|
joshuatcasey
force-pushed
the
jtc/support-k8s-1-28
branch
from
02e1677 to
7a6e3cf
Compare
joshuatcasey
force-pushed
the
jtc/support-k8s-1-28
branch
4 times, most recently
from
ca19553 to
3848509
Compare
joshuatcasey
force-pushed
the
jtc/support-k8s-1-28
branch
13 times, most recently
from
a9d1d54 to
35ad6a3
Compare
|
Reviewing! |
| if event != nil { | ||
| ae = event | ||
| ac := audit.AuditContextFrom(ctx) |
There was a problem hiding this comment.
So, if event is nil, nothing gets created, but this still works? Though we said that Events are no longer pointers?
There was a problem hiding this comment.
But ac.Event = *event is a pointer, and seems to work?
There was a problem hiding this comment.
The type for ac has changed in v0.28.0:
…apiv2' - OpenAPIV3 discovery of aggregate APIs seems to need a little more work in K8s 1.28
joshuatcasey
force-pushed
the
jtc/support-k8s-1-28
branch
from
35ad6a3 to
ca05969
Compare
benjaminapetersen
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Given we consider:
- API Discovery (
kubectl explain) should work for OpenAPIv3 and aggregate APIs #1643 - Aggregate APIs should not have name
Generic API Server#1645
before our next release I'm good with this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.pivotaltracker.com/story/show/185846474 for details.
NOTE: As of 2023-08-20, this has several commits that have workarounds to support things that changed in K8s 1.28. Please review this PR commit-by-commit.