-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design for multi-arch build and windows build #8459
Design for multi-arch build and windows build #8459
Conversation
bf75223
to
6ac48c4
Compare
6ac48c4
to
6bddad2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8459 +/- ##
==========================================
+ Coverage 58.98% 59.00% +0.02%
==========================================
Files 368 368
Lines 39000 39015 +15
==========================================
+ Hits 23004 23022 +18
+ Misses 14532 14530 -2
+ Partials 1464 1463 -1 ☔ View full report in Codecov by Sentry. |
6bddad2
to
2fdeffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.
For reference, we had done something with manifest lists earlier here. Note that we had disabled Travis-CI but .travis.yml here was last working for us. Lines 64 to 77 in fe3907e
|
Will the linux manifest list cover s390x? #2622 |
It is not in the plan. Supporting a new platform not only means support of build, but also installation and running. There is no plan to support all of these for s390. |
The manifest list already work with that. There's no code change at all to install or run when image is a manifest list containing Linux/s390x |
By running, I mean have Velero running on the specific platform, we need to test to identify the gaps and make fixes. For s390 we have no plan nor env to do this. |
Signed-off-by: Lyndon-Li <[email protected]>
2fdeffa
to
3a7cf09
Compare
a4e50f1
to
9744ca7
Compare
Signed-off-by: Lyndon-Li <[email protected]>
9744ca7
to
3723033
Compare
…r for GCR Signed-off-by: Lyndon-Li <[email protected]>
Made some further changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
For the same reason, a new input parameter is added, `BUILD_WINDOWS_VERSION`. The default value is `ltsc2022`. Windows server 2022 is the only base image we will deliver officially, Windows server 2019 is not supported. In future, we may need to support Windows server 2025 base image. | ||
For local build to tar, the Windows OS version is also added to the name of the tarball, e.g., `_output/velero-main-windows-ltsc2022-amd64.tar`. | ||
|
||
At present, Windows container image only supports `amd64` as the architecture, so `BUILD_ARCH` is ignored for Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to note that nanoserver insider has arm. There are not yet GA Windows base images with arm that I can see however.
https://hub.docker.com/r/microsoft/windows-nanoserver-insider
https://mcr.microsoft.com/v2/windows/nanoserver/insider/tags/list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned here, we will consider to support arm for Windows until it is officially supported by Windows container and other major components like Hyper-V, .Net, etc. The build of arm based client or image itself is not a problem
For issue #8429. Add the design for multi-arch build and windows build