Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs about un-enqueueable reason #3065

Merged
merged 1 commit into from
Aug 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions docs/design/podgroup-condition-reason.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# podgroup conditions

## Backgrounds

Currently, there are only two podgroup condition type: `Unschedulable` and `Scheduled`. If job is not enqueued, it has not been scheduled. And the event reason is `Unschedulable` and podgroup condition reason is `NotEnoughResources`. These reasons is not coresponding with the real reason `job is not enqueued`

## Motivation

In order to classify the uninqueueable reason from other unscheduleable reasons

## Design

1. add `Uninqueueable` reason for podgroup events

```go
// PodGroupUnInqueueable is Uninqueueable event type
PodGroupUnInqueueable PodGroupConditionType = "Uninqueueable"
```

2. add `NotInqueueable` reason for podgroup conditions reason

```go
// NotInqueueableReason if probed if job is rejected to enqueue
NotInqueueableReason string = "NotInqueueable"
```
Loading