Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs about un-enqueueable reason #3065

Merged
merged 1 commit into from
Aug 21, 2023
Merged

add docs about un-enqueueable reason #3065

merged 1 commit into from
Aug 21, 2023

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Aug 20, 2023 •
edited
Loading

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 20, 2023
@lowang-bh lowang-bh mentioned this pull request Aug 16, 2023
Open
Thor-wl
Thor-wl reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. That helps a lot for users to get more details about job's status. I remember @hwdef has ever mentioned this ever. Let's review together to make it better. It's OK for me now.

hwdef
hwdef reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@volcano-sh-bot volcano-sh-bot merged commit 36abf1b into volcano-sh:master Aug 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@Thor-wl Thor-wl Thor-wl approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@wangyang0616 wangyang0616 Awaiting requested review from wangyang0616

Assignees

@hwdef hwdef

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lowang-bh @volcano-sh-bot @hwdef @Thor-wl