Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci and add event logging to help debug ci #3817

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

JesseStutler
Copy link
Member

@JesseStutler JesseStutler commented Nov 13, 2024

  1. Fix spark ci, add Free Disk Space step
  2. Upgrade busybox and nginx image to use latest image, otherwise it will cause image pull failure:
The pod <ypari8nv/qj-1-qj-1-task-0-5> is not in Succeeded phaseEvent related with pod <ypari8nv/qj-1-qj-1-task-0-5>: Failed - Failed to pull image "busybox:1.24": failed to pull and unpack image "docker.io/library/busybox:1.24": no signatures
  1. Add event logging for WaitTaskPhase validation, if the phase of pod is not in phase slice, query the events related with it and log, help us to debug ci when ci fails.
image

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2024
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
@JesseStutler JesseStutler changed the title [WIP]feature: add event logging related with abnormal pod to help debug ci fix ci and event logging to help debug ci Nov 13, 2024
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@JesseStutler JesseStutler changed the title fix ci and event logging to help debug ci fix ci and add event logging to help debug ci Nov 13, 2024
@JesseStutler
Copy link
Member Author

/assign @Monokaix

@JesseStutler
Copy link
Member Author

@Monokaix @hwdef Please help have a review.

@SherlockShemol
Copy link
Contributor

Hero! 🌹

Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@hwdef
Copy link
Member

hwdef commented Nov 13, 2024

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 13, 2024
@dongjiang1989
Copy link
Contributor

Great!

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@Monokaix
Copy link
Member

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants