Altsound: Fixed bug with parsing of WPCDCS, WPCSECURITY, WPC95DCS, and WPC95 commands #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was brought to my attention that the Theatre of Magic altsound was exhibiting strange behavior. On ball 1, the sounds would either not be playing or playing the incorrect sound.
After investigating this, it was discovered that code meant to signal a problem with parsing was actually causing a problem. The details of the problem can be found here
The fix involves simply removing the line of code that performs this check. If the problem which caused this line to be necessary arises again, it should be re-evaluated and addressed with a more robust remedy.