Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altsound: Fixed bug with parsing of WPCDCS, WPCSECURITY, WPC95DCS, and WPC95 commands #224

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Altsound: Fixed bug with parsing of WPCDCS, WPCSECURITY, WPC95DCS, and WPC95 commands #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47edcca
Fix for bad command parsing for some WPC generation hardware
droscoe Feb 8, 2024
8f9f4b8
Fixed bug with WPCDCS, WPCSECURITY, WPC95DCS, WPC95 altsound command …
droscoe Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/wpc/altsound/snd_alt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,14 @@ void preprocess_commands(CmdData* cmds_out, int cmd_in)

ALT_DEBUG(0, "Hardware Generation: GEN_WPCDCS, GEN_WPCSECURITY, GEN_WPC95DCS, GEN_WPC95");

if (((cmd_buffer[3] == 0x55) && (cmd_buffer[2] == 0xAA)) // change volume?
||
((cmd_buffer[2] == 0x00) && (cmd_buffer[1] == 0x00) && (cmd_buffer[0] == 0x00))) // glitch in command buffer?
if (((cmd_buffer[3] == 0x55) && (cmd_buffer[2] == 0xAA))) // change volume?
// DAR@20240208 The check below is dangerous. If this is still a
// problem, it would be better to revisit it when it
// reappears to implement a more robust solution that
// works for all systems
// See https://github.com/vpinball/pinmame/issues/220
//||
//((cmd_buffer[2] == 0x00) && (cmd_buffer[1] == 0x00) && (cmd_buffer[0] == 0x00))) // glitch in command buffer?
{
if ((cmd_buffer[3] == 0x55) && (cmd_buffer[2] == 0xAA) && (cmd_buffer[1] == (cmd_buffer[0] ^ 0xFF))) { // change volume op (following first byte = volume, second = ~volume, if these don't match: ignore)
// DAR@20230518
Expand Down
Loading