Remove dependency on Data Recvd signals in cleanup #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simplification, which will cause applications to see errors more often, but I think that it is a good one. Closes w3c#581.
jan-ivar
reviewed
Jan 24, 2024
| 1. [=Queue a network task=] with |transport| to run these steps: | ||
| 1. If |transport|.{{[[State]]}} is `"closed"` or `"failed"`, abort these steps. | ||
| 1. Let |error| be a newly [=DOMException/created=] {{WebTransportError}} whose | ||
| {{WebTransportErrorOptions/source}} is `"session"`. | ||
| 1. If |cleanly| is false, then [=cleanup=] |transport| with |error|, and abort these steps. |
There was a problem hiding this comment.
This is a simplification, which will cause applications to see errors more often, but I think that it is a good one.
This line removes erroring (the call to cleanup without closeInfo, unlike below), so won't applications see errors less often?
There was a problem hiding this comment.
The net effect is that cleanup is invoked with closeInfo always. So I figured they would see that more often, as opposed to just when the local side of the transport thought that it had no outstanding work at the time.
github-actions bot
added a commit
that referenced
this pull request
Jan 31, 2024
SHA: ee82272 Reason: push, by jan-ivar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplification, which will cause applications to see errors more often, but I think that it is a good one.
Closes #581.
Preview | Diff