Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on Data Recvd signals in cleanup #582

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Remove dependency on Data Recvd signals in cleanup #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,13 +1155,10 @@ series of steps |steps|, run these steps:
Whenever a [=WebTransport session=] which is associated with a {{WebTransport}} |transport| is
[=session/terminated=] with optionally |code| and |reasonBytes|, run these steps:

1. Let |cleanly| be a boolean representing whether |transport|.{{[[Session]]}}'s [=CONNECT stream=]
is in the "Data Recvd" state. [[!QUIC]]
1. [=Queue a network task=] with |transport| to run these steps:
1. If |transport|.{{[[State]]}} is `"closed"` or `"failed"`, abort these steps.
1. Let |error| be a newly [=DOMException/created=] {{WebTransportError}} whose
{{WebTransportErrorOptions/source}} is `"session"`.
1. If |cleanly| is false, then [=cleanup=] |transport| with |error|, and abort these steps.
Copy link
Member

@jan-ivar jan-ivar Jan 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simplification, which will cause applications to see errors more often, but I think that it is a good one.

This line removes erroring (the call to cleanup without closeInfo, unlike below), so won't applications see errors less often?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The net effect is that cleanup is invoked with closeInfo always. So I figured they would see that more often, as opposed to just when the local side of the transport thought that it had no outstanding work at the time.

1. Let |closeInfo| be a [=new=] {{WebTransportCloseInfo}}.
1. If |code| is given, set |closeInfo|'s {{WebTransportCloseInfo/closeCode}} to |code|.
1. If |reasonBytes| is given, set |closeInfo|'s {{WebTransportCloseInfo/reason}} to |reasonBytes|,
Expand Down
Loading