Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove negation from redis install condition #186

Closed
wants to merge 1 commit into from

Conversation

vijay-wandb
Copy link

@vijay-wandb vijay-wandb commented Dec 4, 2024

Redis is being created even though create_redis is explicitly set to false in the deployment using the GCP Terraform module public-dns-with-cloud-dns.

Here’s the variable definition:

variable "create_redis" {
  default     = false
  description = "Boolean indicating whether to provision a Redis instance (true) or not (false)."
  nullable    = false
  type        = bool
}

The logic in the module at main.tf#L362 appears to cause the issue:

redis = { install = !var.create_redis }

@vijay-wandb vijay-wandb requested a review from a team as a code owner December 4, 2024 16:24
@vijay-wandb vijay-wandb changed the title Remove negation from redis install condition fix - Remove negation from redis install condition Dec 4, 2024
@vijay-wandb vijay-wandb changed the title fix - Remove negation from redis install condition fix: Remove negation from redis install condition Dec 4, 2024
@danielpanzella
Copy link
Contributor

The create_redis variable when set to true will create a managed redis instance and disable the in cluster redis, as well as wire through the appropriate connection information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants