fix(calling): removed-events-dependency-on-call-buttons #3147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES
This pull request addresses
In the calling samples page, if we don't receive the CALL_ESTABLISHED event the samples page gets stuck. The 'end-call' button remains disabled.
by making the following changes
We have removed the dependency of any event on the button state. As soon as we make the call 'end-call' button is enabled and we can cut the call.
Also
The advanced settings or region and country take effect when the calling.init() button is pressed. But the button is located above the Advanced section. So a user will miss the chance to change the settings before initializing calling. So moved the 'Initialize Calling' button bellow Advanced settings
Changed UI in credentials section
Dialing a number that is not part of the org
Screen.Recording.2023-10-13.at.2.27.31.PM.mov
Dialing a number that is part of the org
Screen.Recording.2023-10-13.at.2.33.59.PM.mov
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.