Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calling): removed-events-dependency-on-call-buttons #3147

Merged

Conversation

Shreyas281299
Copy link
Contributor

@Shreyas281299 Shreyas281299 commented Oct 13, 2023

COMPLETES

This pull request addresses

In the calling samples page, if we don't receive the CALL_ESTABLISHED event the samples page gets stuck. The 'end-call' button remains disabled.

by making the following changes

We have removed the dependency of any event on the button state. As soon as we make the call 'end-call' button is enabled and we can cut the call.
Also
The advanced settings or region and country take effect when the calling.init() button is pressed. But the button is located above the Advanced section. So a user will miss the chance to change the settings before initializing calling. So moved the 'Initialize Calling' button bellow Advanced settings

Changed UI in credentials section

Screenshot 2023-10-13 at 3 28 16 PM

Dialing a number that is not part of the org

Screen.Recording.2023-10-13.at.2.27.31.PM.mov

Dialing a number that is part of the org

Screen.Recording.2023-10-13.at.2.33.59.PM.mov

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@Shreyas281299 Shreyas281299 added the validated If the pull request is validated for automation. label Oct 13, 2023
@Shreyas281299 Shreyas281299 requested a review from a team as a code owner October 13, 2023 09:05
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3147.d3m3l2kee0btzx.amplifyapp.com

Copy link
Contributor

@sreenara sreenara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Thanks.
There was another issue I noticed in the samples page.

image

In the above image, the workflow can be mis-understood by a user. The advanced settings or region and country take effect when the calling.init() button is pressed. But the button is located above the Advanced section. So a user will miss the chance to change the settings before initializing calling.
The expectation is to move the calling.init() button below the Advanced settings so it's clear that initialization will take them into account too.

Also, can we reword calling.init() to 'Initialize Calling'?

@Shreyas281299 Shreyas281299 force-pushed the remove-event-dependency-on-call-buttons branch from 7299669 to c2a2175 Compare October 13, 2023 09:33
@Shreyas281299 Shreyas281299 reopened this Oct 13, 2023
@Shreyas281299
Copy link
Contributor Author

Changes look fine. Thanks. There was another issue I noticed in the samples page.

image

In the above image, the workflow can be mis-understood by a user. The advanced settings or region and country take effect when the calling.init() button is pressed. But the button is located above the Advanced section. So a user will miss the chance to change the settings before initializing calling. The expectation is to move the calling.init() button below the Advanced settings so it's clear that initialization will take them into account too.

Also, can we reword calling.init() to 'Initialize Calling'?

Made the changes.

@Shreyas281299 Shreyas281299 force-pushed the remove-event-dependency-on-call-buttons branch from 175dd3e to de53c30 Compare October 13, 2023 09:53
@sreenara sreenara merged commit 6159f1c into webex:next Oct 13, 2023
@Shreyas281299 Shreyas281299 deleted the remove-event-dependency-on-call-buttons branch August 6, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants