fix(meetings): fix types #3602
fix(meetings): fix types #3602
Conversation
Shreyas281299
added
the
validated
|
Code refactor of util.ts and utilv2.ts was required because with the existing code we were getting an empty declaration files. |
Please mark this comment next to the place where the refactor was done |
| if (type === _LOCUS_ID_) { | ||
| if (!(destination && destination.url)) { | ||
| throw new ParameterError('You cannot create a meeting by locus without a locus.url defined'); | ||
| /** |
There was a problem hiding this comment.
The refactor of util.ts is required as without this refactor an empty declaration file was being created.
For the refactor
- Created a class MeetingInfoUtil
- All the methods inside the class are static. No src code changes are made.
There was a problem hiding this comment.
Thanks for this comment. I like it :-)
| const MeetingInfoUtil: any = {}; | ||
| const meetingInfoError = | ||
| 'MeetingInfo is fetched with the meeting link, SIP URI, phone number, Hydra people ID, or a conversation URL.'; | ||
| /** |
There was a problem hiding this comment.
The refactor of utilv2.ts is required as without this refactor an empty declaration file was being created.
For the refactor
- Create a class MeetingInfoUtil
- All the methods inside the class are static. No src code changes are made.
| @@ -41,8 +42,9 @@ | |||
| "sinon": "^9.2.4" | |||
| }, | |||
| "scripts": { | |||
| "build": "yarn build:src", | |||
| "build:src": "webex-legacy-tools build -dest \"./dist\" -src \"./src\" -js -ts -maps", | |||
| "ls": "pwd", | |||
There was a problem hiding this comment.
@Shreyas281299 why do we want to add the ls command here ?
Also ls is doing pwd ? pwd is to get full path name of your current directory but ls is for listing files.
There was a problem hiding this comment.
@Neeraj-swarnkar thanks. No this was added by mistake. I was testing something thats why I added this. Removing it now.
| if (type === _LOCUS_ID_) { | ||
| if (!(destination && destination.url)) { | ||
| throw new ParameterError('You cannot create a meeting by locus without a locus.url defined'); | ||
| /** |
There was a problem hiding this comment.
Thanks for this comment. I like it :-)
COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-502998
This pull request addresses
Export important classes, objects, and constants in plugin-meetings. This will make sure we dont have to import them from from '/dist' folder in WWC.
In internal-plugin-voicea, we were not creating declaration files.
by making the following changes
Change Type
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.