Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meetings): fix types #3602

Merged
merged 5 commits into from
Jun 5, 2024
Merged

fix(meetings): fix types #3602

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f04c5df
fix(meetings): fix types
ShreyasSharma28 May 15, 2024
e901025
fix(internal-plugin-voicea): add tsconfig
ShreyasSharma28 May 17, 2024
c764f9e
Merge remote-tracking branch 'upstream/next' into fix-meetings-voicea…
ShreyasSharma28 May 23, 2024
36b9932
fix(plugin-voicea): remove-unwanted-script
Shreyas281299 May 24, 2024
440b175
Merge branch 'next' into fix-meetings-voicea-types
Shreyas281299 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/@webex/internal-plugin-voicea/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"description": "",
"license": "Cisco EULA (https://www.cisco.com/c/en/us/products/end-user-license-agreement.html)",
"main": "dist/index.js",
"types": "dist/types/index.d.ts",
"devMain": "src/index.js",
"repository": {
"type": "git",
Expand Down Expand Up @@ -41,8 +42,9 @@
"sinon": "^9.2.4"
},
"scripts": {
"build": "yarn build:src",
"build:src": "webex-legacy-tools build -dest \"./dist\" -src \"./src\" -js -ts -maps",
"ls": "pwd",
sreenara marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shreyas281299 why do we want to add the ls command here ?
Also ls is doing pwd ? pwd is to get full path name of your current directory but ls is for listing files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neeraj-swarnkar thanks. No this was added by mistake. I was testing something thats why I added this. Removing it now.

"build": "yarn run -T tsc --declaration true --declarationDir ./dist/types",
"build:src": "webex-legacy-tools build -dest \"./dist\" -src \"./src\" -js -ts -maps && yarn build",
"deploy:npm": "yarn npm publish",
"test": "yarn test:style && yarn test:unit && yarn test:integration && yarn test:browser",
"test:browser": "webex-legacy-tools test --integration --runner karma",
Expand Down
6 changes: 6 additions & 0 deletions packages/@webex/internal-plugin-voicea/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../../../tsconfig.json",
"include": [
"src"
],
}
2 changes: 1 addition & 1 deletion packages/@webex/plugin-meetings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
]
},
"scripts": {
"build": "yarn run -T tsc --declaration true --declarationDir ./dist",
"build": "yarn run -T tsc --declaration true --declarationDir ./dist/types",
mkesavan13 marked this conversation as resolved.
Show resolved Hide resolved
"build:src": "webex-legacy-tools build -dest \"./dist\" -src \"./src\" -js -ts -maps && yarn build",
"deploy:npm": "yarn npm publish",
"test:broken": "yarn test:style && yarn test:unit && yarn test:integration && yarn test:browser",
Expand Down
27 changes: 27 additions & 0 deletions packages/@webex/plugin-meetings/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ import {registerPlugin} from '@webex/webex-core';
import Meetings from './meetings';
import config from './config';
import {LocusRetryStatusInterceptor} from './interceptors';
import CaptchaError from './common/errors/captcha-error';
import IntentToJoinError from './common/errors/intent-to-join';
import PasswordError from './common/errors/password-error';
import PermissionError from './common/errors/permission';
import {
ReclaimHostEmptyWrongKeyError,
ReclaimHostIsHostAlreadyError,
ReclaimHostNotAllowedError,
ReclaimHostNotSupportedError,
} from './common/errors/reclaim-host-role-errors';
import Meeting from './meeting';

registerPlugin('meetings', Meetings, {
config,
Expand Down Expand Up @@ -39,6 +50,22 @@ export default Meetings;

export * as CONSTANTS from './constants';
export * as REACTIONS from './reactions/reactions';
export * as sdkAnnotationTypes from './annotation/annotation.types';
export * as MeetingInfoUtil from './meeting-info/utilv2';
export * as MeetingInfoV2 from './meeting-info/meeting-info-v2';
export {type Reaction} from './reactions/reactions.type';

export {
CaptchaError,
IntentToJoinError,
PasswordError,
PermissionError,
ReclaimHostIsHostAlreadyError,
ReclaimHostNotAllowedError,
ReclaimHostNotSupportedError,
ReclaimHostEmptyWrongKeyError,
Meeting,
};

export {RemoteMedia} from './multistream/remoteMedia';

Expand Down
Loading
Loading