fix: conditionally add device permissions #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvujic
requested review from
szotrabh,
SomeBody16,
antsukanova and
k-wasniowski
bbaldino
previously approved these changes
Sep 19, 2024
edvujic
changed the title
antsukanova
reviewed
Sep 20, 2024
bbaldino
pushed a commit
that referenced
this pull request
Sep 20, 2024
## [2.10.3](v2.10.2...v2.10.3) (2024-09-20) ### Bug Fixes * conditionally add device permissions ([#86](#86)) ([9e2d55a](9e2d55a))
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes SPARK-563488
This PR introduces improvements and additions to the device management functionality, including conditional device permissions and unit tests.
getDevices()function checks for all permissions irrespective of what the user has passed asdeviceKind. This can cause unnecessary permission prompts for devices that aren't needed by the user.This can be tested with: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-539683