Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shorts #235

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Fix shorts #235

wants to merge 9 commits into from

Conversation

fire332
Copy link
Collaborator

@fire332 fire332 commented Dec 18, 2024

This PR is built on top of #234. That should be dealt with before this one.

Fixes #210, fixes #211, fixes #219

Changes

  • Allow using TypeScript in app code by adding TypeScript support to babel.
  • Fix thumbnails in the shorts shelf.
  • Fix stretched/offset shorts player by changing the screensaver fix to not apply when not using the watch (full-screen player) page.
  • Disable "Remove Shorts from subscriptions" by default.

@fire332
Copy link
Collaborator Author

fire332 commented Dec 19, 2024

Whoops. Had a brain fart when refactoring the screensaver fix.

@cremor
Copy link

cremor commented Dec 20, 2024

Thanks for working on this problem!
I've tested your changes (with a build based on #236) any I can indeed see the video of shorts again. But the video is not placed exactly in the correct area. There is a part of black space on the left side of the video area, and the right side of the video is cut off.

@fire332
Copy link
Collaborator Author

fire332 commented Dec 20, 2024

@cremor can you take a picture?

@cremor
Copy link

cremor commented Dec 20, 2024

Sure. This is on an OLED C9 with WebOS 4.10.0:
Short

@fire332
Copy link
Collaborator Author

fire332 commented Dec 20, 2024

How did you take this picture? It looks more like the video is in the correct spot but the entire UI is offset

@cremor
Copy link

cremor commented Dec 20, 2024

It's just a photo I took with my phone. The short video was paused there, but that doesn't make a difference.
The thumbnail, which is visible for a moment before the short video playback starts, is not cut off. Only the actual video stream is.

@cremor
Copy link

cremor commented Dec 20, 2024

It looks more like the video is in the correct spot but the entire UI is offset

You are right. The white border isn't in the center of the screen. The video itself seems to be in the center.
But what could cause this? I never had this problem before the shorts video stopped being shown a few weeks/months back.

@fire332
Copy link
Collaborator Author

fire332 commented Dec 20, 2024

Do you know how to use the web inspector tool? Can you check the computed styles of the top-most element that's offset incorrectly?

@cremor
Copy link

cremor commented Dec 20, 2024

No, but I think I could figure it out with a few hints. What software would I use to do that? I've only used WebOS Device Manager to install the app on the TV.

@fire332
Copy link
Collaborator Author

fire332 commented Dec 20, 2024

You need node.js 22 LTS installed. Then download a copy of this repository and open the folder in terminal. Then run:

npm install
ares-inspect -a youtube.leanback.v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants