Feature: upgrade thumbnail quality #236
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire332
force-pushed
the
thumbnail-quality
branch
from
06e3ee9 to
1ece14b
Compare
fire332
force-pushed
the
thumbnail-quality
branch
from
1ece14b to
81ca63d
Compare
Draft
|
Thank you! Will this be in the next release or how do I install this fix onto my 0.3.4 version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to upgrade the quality of thumbnail images that is disabled by default. It doesn't upgrade thumbnails for shorts or if it's from an A/B test (I'm not sure A/B test thumbnails even have a higher quality than hqdefault).
It works by detecting thumbnail elements, parsing their URLs from their
background-imageinline style, rewriting the URL to use a higher quality version & with WebP if supported, loading the image in the background, and finally swapping the images out if it loads successfully.This PR is built on top of #235. That should be merged before this one.
Fixes #175, fixes #196, fixes #231