Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update collections list empty state #2303

Merged
merged 3 commits into from
Jan 14, 2025
Merged

refactor: Update collections list empty state #2303

merged 3 commits into from
Jan 14, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jan 14, 2025 •
edited
Loading

WIP for #2304

Changes

Makes collection list empty state more consistent with other empty states.

Screenshots

Page Image/video
Collections (crawler role) Screenshot 2025-01-13 at 4 58 06 PM
Collections (viewer role) Screenshot 2025-01-13 at 4 58 17 PM

Follow-ups

With emptyMessage added to layouts it should be a straightforward refactor for all top-level empty states--created #2304

@SuaYoo SuaYoo mentioned this pull request Jan 14, 2025
Open
@SuaYoo SuaYoo changed the base branch from main to public-collections-feature January 14, 2025 01:04
@SuaYoo SuaYoo marked this pull request as ready for review January 14, 2025 01:04
@SuaYoo SuaYoo requested review from Shrinks99 and emma-sg January 14, 2025 01:04
@Shrinks99
Copy link
Member

Given that this removes the renderEmpty function, I think we can also remove the import statement for no-collections-found.webp and finally put that graphic to rest (yeet it from the codebase)

Base automatically changed from public-collections-feature to main January 14, 2025 03:32
@SuaYoo
Copy link
Member Author

SuaYoo commented Jan 14, 2025

Given that this removes the renderEmpty function, I think we can also remove the import statement for no-collections-found.webp and finally put that graphic to rest (yeet it from the codebase)

Good catch!

@SuaYoo SuaYoo changed the title Update collections list empty state refactor: Update collections list empty state Jan 14, 2025
Shrinks99
Shrinks99 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SuaYoo SuaYoo merged commit a028ed1 into main Jan 14, 2025
5 checks passed
@SuaYoo SuaYoo deleted the public-collections-feature--empty branch January 14, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shrinks99 Shrinks99 Shrinks99 approved these changes

@emma-sg emma-sg Awaiting requested review from emma-sg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuaYoo @Shrinks99