Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left Nav bar Menu #1139
Left Nav bar Menu #1139
Changes from 6 commits
bfe33db
f37ba3b
89d6724
3811663
67110e8
06eec37
ffcc4e3
7c687bf
2c22e11
a480c01
33a5b59
3a8d3ec
2cb5e3e
a179b63
7ab7199
93dbfd6
6d8295f
b3b8c48
fee8cd8
3537b43
0d11905
e5a9eb5
61d56ee
31b69ff
89c4a44
f9ff9a8
a61fa9e
decd2db
d1ece00
8cf6787
decbb55
e35deb5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
Listening Events
is better, how do you think of this @huanThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looping me in.
I think both of the names are ok, and the differences between them are minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since, the differences is minor. I feel making it short can make better experience for the user :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you change to
Deal with messages
, I think these two parts should be unified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you change to
Send and accept friend requests
, I think these two parts should be unified.