Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left Nav bar Menu #1139

Merged
merged 32 commits into from
Nov 26, 2021
Merged

Left Nav bar Menu #1139

merged 32 commits into from
Nov 26, 2021

Conversation

abhishek-iiit
Copy link
Member

@abhishek-iiit abhishek-iiit commented Jul 25, 2021 •
edited
Loading

Redefined left-sidebar

Screenshot from 2021-07-29 22-23-19

@abhishek-iiit abhishek-iiit requested review from a team as code owners July 25, 2021 10:08
@abhishek-iiit
Copy link
Member Author

Reopen of PR #946 & linked to issue #896

@abhishek-iiit abhishek-iiit mentioned this pull request Jul 25, 2021
Closed
@abhishek-iiit abhishek-iiit self-assigned this Jul 25, 2021
@abhishek-iiit abhishek-iiit added GSoD 2021 how to guide PR related to How-to-Guide section labels Jul 25, 2021
@abhishek-iiit abhishek-iiit mentioned this pull request Jul 25, 2021
Closed
proudofsimin
proudofsimin approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is great.

lijiarui
lijiarui requested changes Jul 29, 2021
View reviewed changes
docusaurus/docs/howto/event.mdx Outdated
@@ -1,5 +1,5 @@
---
title: 'Listening events'
title: 'Add events and customise a bot'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Listening Events is better, how do you think of this @huan

Copy link
Member

@huan huan Jul 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looping me in.

I think both of the names are ok, and the differences between them are minor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, the differences is minor. I feel making it short can make better experience for the user :)

@abhishek-iiit abhishek-iiit requested a review from lijiarui July 29, 2021 17:01
lijiarui
lijiarui approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohitesh-Kumar-Jain
Copy link
Contributor

@abhishek-iiit pls remove the merge conflict and then ping for merge

lijiarui
lijiarui requested changes Aug 23, 2021
View reviewed changes
docusaurus/docs/howto/howto_docker.mdx Outdated Show resolved Hide resolved
docusaurus/sidebars.ts Outdated Show resolved Hide resolved
@Rohitesh-Kumar-Jain
Copy link
Contributor

@vasvi-sood @abhishek-iiit

@Rohitesh-Kumar-Jain
Copy link
Contributor

@vasvi-sood @abhishek-iiit pls help us proceed towards the merge :)

lijiarui
lijiarui previously requested changes Oct 18, 2021
View reviewed changes
docusaurus/docs/howto/deploy-whatsapp.mdx Outdated Show resolved Hide resolved
docusaurus/docs/howto/deploy-whatsapp.mdx Outdated Show resolved Hide resolved
docusaurus/docs/howto/deploy-whatsapp.mdx Outdated Show resolved Hide resolved
docusaurus/docs/howto/deploy-whatsapp.mdx Show resolved Hide resolved
docusaurus/docs/howto/heroku.mdx Outdated Show resolved Hide resolved
docusaurus/docs/howto/heroku.mdx Outdated Show resolved Hide resolved
@Rohitesh-Kumar-Jain
Copy link
Contributor

ping @lijiarui

@abhishek-iiit abhishek-iiit mentioned this pull request Oct 28, 2021
Merged
@shraddhavp
Copy link
Contributor

@abhishek-iiit please resolve the merge conflict ,then we are good to merge

@shraddhavp shraddhavp disabled auto-merge November 17, 2021 11:03
@shraddhavp shraddhavp dismissed lijiarui’s stale review November 17, 2021 11:04

the changes requested by Rui is done and is ready for merging

@Rohitesh-Kumar-Jain
Copy link
Contributor

@abhishek-iiit pls resolve the conflicts

@abhishek-iiit
Copy link
Member Author

@abhishek-iiit pls resolve the conflicts

@Rohitesh-Kumar-Jain conflict resolved, thankyou :)

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain merged commit 3ee6238 into wechaty:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasvi-sood vasvi-sood vasvi-sood approved these changes

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

@huan huan huan approved these changes

@lijiarui lijiarui Awaiting requested review from lijiarui

Assignees

@abhishek-iiit abhishek-iiit

Labels
GSoD 2021 how to guide PR related to How-to-Guide section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abhishek-iiit @Rohitesh-Kumar-Jain @shraddhavp @huan @lijiarui @proudofsimin @vasvi-sood