Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFMP-269] Allow multiple deployments to be used for the package goal #604

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Nov 27, 2024

This is a replacement for #561

@jfdenise WDYT? The idea is you don't need include a deployment definition for each extra deployment. For example in the demo project, you'd simple add:

<included-dependencies>
    <include>::ear</include>
</included-dependencies>

OR

<included-dependencies>
    <include>demo.multiapps</include>
</included-dependencies>

@jamezp
Copy link
Member Author

jamezp commented Nov 27, 2024

Maybe it should be included-deployments instead of included-dependencies.

@jfdenise
Copy link
Contributor

@jamezp , I like the dependencies in the name, this is what they are, no confusion with File path,...
perhaps deployed-dependencies?

@jamezp
Copy link
Member Author

jamezp commented Dec 2, 2024

@jamezp , I like the dependencies in the name, this is what they are, no confusion with File path,... perhaps deployed-dependencies?

This makes a lot more sense. I'll update the PR.

@jamezp jamezp force-pushed the WFMP-269 branch 2 times, most recently from b3b8275 to c5c3e78 Compare December 2, 2024 19:17
…x object for deployments.

https://issues.redhat.com/browse/WFMP-269
Signed-off-by: James R. Perkins <jperkins@redhat.com>
@jamezp jamezp merged commit ef9b602 into wildfly:main Dec 3, 2024
11 of 12 checks passed
@jamezp jamezp deleted the WFMP-269 branch December 3, 2024 00:01
@torsten-liermann
Copy link

I liked the approach with the dependencies because it corresponds, for example, to the maven-war and maven-ear plugins. In my case, what needs to be deployed comes from the Maven build and can always be easily referenced as a Maven artifact. From my understanding as a long-time Maven user, this is simply consistent.

@jamezp
Copy link
Member Author

jamezp commented Dec 5, 2024

@torsten-liermann I'm not sure I follow. This approach does use dependencies. You've just to got explicitly state what you want included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants