feat: call setMetadata() in createDao() #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aodhgan
changed the base branch from
sta-36-consider-calling-_setdaometadata-in
to
main
aodhgan
changed the title
|
@CjHare Do the workflow checks run on these branches? |
Rieranthony
approved these changes
Oct 3, 2022
|
@Rieranthony Thanks but I think you need to be in this group to approve merge https://github.com/orgs/windranger-io/teams/windranger-core/members |
Strange, the check should be running against branches on forks ....must be something in the GitHub settings for the project 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose for this PR
as per #359