-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: message status not updated while using the fire and forget asset mechanism (WPB-4519) #2061
fix: message status not updated while using the fire and forget asset mechanism (WPB-4519) #2061
Conversation
Codecov Report
@@ Coverage Diff @@
## release/candidate #2061 +/- ##
====================================================
Coverage ? 58.04%
Complexity ? 24
====================================================
Files ? 1004
Lines ? 37580
Branches ? 3431
====================================================
Hits ? 21813
Misses ? 14295
Partials ? 1472 Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! 🪱 🐦 👏 But I still can't think why we never even considered this buggy scenario for non-federated scenarios.
.../commonTest/kotlin/com/wire/kalium/logic/feature/asset/ScheduleNewAssetMessageUseCaseTest.kt
Outdated
Show resolved
Hide resolved
… mechanism (WPB-4519) (#2061) * fix: add failure handling while remote be is offline for assests scheduler mechanism * fix: coverage * fix: coverage * fix: coverage
… mechanism (WPB-4519) (#2064) * fix: message status not updated while using the fire and forget asset mechanism (WPB-4519) (#2061) * fix: add failure handling while remote be is offline for assests scheduler mechanism * fix: coverage * fix: coverage * fix: coverage * Empty-Commit --------- Co-authored-by: Yamil Medina <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
While using
ScheduleNewAssetMessageUseCase
to upload assets and the backend has the federator down (technically online but not reachable to/from by other backends) the asset is uploaded but sending the message fails not reflecting this state in the database.Causes (Optional)
No button to retry is visible, and the asset message shows as pending.
Solutions
Update the status of the message when we can't send the message with our
MessageSendFailureHandler
component, so can be correctly updated toFAILED
accordingly.Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.