feat: typing indicator receiver events and observability (WPB-4591) #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2069 +/- ##
=============================================
- Coverage 57.95% 57.93% -0.03%
Complexity 24 24
=============================================
Files 1012 1016 +4
Lines 38020 38104 +84
Branches 3458 3466 +8
=============================================
+ Hits 22035 22076 +41
- Misses 14501 14542 +41
- Partials 1484 1486 +2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
gongracr
reviewed
Sep 18, 2023
...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/TypingIndicatorRepository.kt
Outdated
Show resolved
Hide resolved
yamilmedina
requested review from
a team,
gongracr and
alexandreferris
and removed request for
a team
vitorhugods
requested changes
Sep 18, 2023
...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/TypingIndicatorRepository.kt
Outdated
Show resolved
Hide resolved
| class TypingIndicatorRepositoryImpl : TypingIndicatorRepository { | ||
|
|
||
| private val userTypingDataSourceFlow = MutableSharedFlow<Unit>(extraBufferCapacity = 1, onBufferOverflow = BufferOverflow.DROP_OLDEST) | ||
| private val userTypingCache = ConcurrentMutableMap<ConversationId, Set<ExpiringUserTyping>>() |
There was a problem hiding this comment.
This makes it so this Repository needs to be "static" a.k.a. we need to create one for each user, can't just have getters like most repositories.
It would be nice to make this more explicit by passing the MutableMap<ConversationId, Set<ExpiringUserTyping>> as a parameter in the constructor.
There was a problem hiding this comment.
Good idea, done !
...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/TypingIndicatorRepository.kt
Outdated
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
vitorhugods
approved these changes
Sep 25, 2023
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
This is the receiving part of typing indicator events,
STARTEDandSTOPPEDSolutions
Given that typing indicator events are
transient = true, we are not persisting it, but rather handling them in memory.There will come another PR for expiring this cache entries, accordingly to specs, for now we expect that other clients always send
STOPPEDTesting
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.