Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: typing indicator receiver events and observability (WPB-4591) #2069
feat: typing indicator receiver events and observability (WPB-4591) #2069
Changes from 9 commits
6399438
72e324d
b1a7cdb
de5bac1
46344d2
46982e5
060a8d3
666cecf
2df92e9
0bfe0d7
e2e5b95
1f45f08
37a2268
091d1b6
aad9216
82851f5
7a567fd
8aaa732
b7e8f96
2057634
21ed23b
e24e1d6
289cf07
ebb1cd5
44b9a91
fdb6f1d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it so this Repository needs to be "static" a.k.a. we need to create one for each user, can't just have getters like most repositories.
It would be nice to make this more explicit by passing the
MutableMap<ConversationId, Set<ExpiringUserTyping>>
as a parameter in the constructor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, done !